ref(relay): Only update internal state when it changed #76594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Dav1dde
force-pushed
the
dav1d/relay-internal
branch
from
63b9759
to
7ad5557
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76594 +/- ##
===========================================
+ Coverage 56.44% 78.17% +21.72%
===========================================
Files 6891 6904 +13
Lines 306655 306920 +265
Branches 52826 52821 -5
===========================================
+ Hits 173090 239921 +66831
+ Misses 128972 60606 -68366
- Partials 4593 6393 +1800 |
Dav1dde
force-pushed
the
dav1d/relay-internal
branch
from
7ad5557
to
497716d
Compare
beezz
approved these changes
Aug 27, 2024
Dav1dde
force-pushed
the
dav1d/relay-internal
branch
from
497716d
to
e31fa49
Compare
jjbayer
approved these changes
Aug 27, 2024
Dav1dde
force-pushed
the
dav1d/relay-internal
branch
from
e31fa49
to
4a9a534
Compare
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
|
PR. does what it was supposed to do: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
is_internalupdate from therelay_from_idfunction, to move the check to the endpoint (where it already was anyways). All additional uses ofrelay_from_iddon't seem to care about the internal state, except authentication.So that seems fine, also this behaviour does seem more consistent.